Add an informative error message if the solver has not been instantiated#706
Closed
johannahaffner wants to merge 1 commit intopatrick-kidger:devfrom
Closed
Add an informative error message if the solver has not been instantiated#706johannahaffner wants to merge 1 commit intopatrick-kidger:devfrom
johannahaffner wants to merge 1 commit intopatrick-kidger:devfrom
Conversation
| # Check if the solver is an instance of AbstractSolver and provide an informative | ||
| # error if it is not. Addresses https://github.com/patrick-kidger/diffrax/issues/705 | ||
| if not isinstance(solver, AbstractSolver): | ||
| if issubclass(solver, AbstractSolver): |
Owner
There was a problem hiding this comment.
This will error out if solver is not a class. We need isinstance(solver, type) and issubclass(solver, AbstractSolver).
| if issubclass(solver, AbstractSolver): | ||
| msg = ( | ||
| "It looks like you forgot to instantiate your solver, e.g. by passing " | ||
| "`dfx.Euler` instead of `dfx.Euler()`." |
Owner
There was a problem hiding this comment.
The dfx abbreviation isn't as standardized as eqx is; I think we should write out diffrax instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #705.